From f337008819125d6ccb039220260b81117882a971 Mon Sep 17 00:00:00 2001 From: Daniel M Brasil Date: Wed, 23 Aug 2023 10:50:23 -0300 Subject: [PATCH 1/3] Fix timeout on invalid set of exclusionary parameters in `/api/v1/timelines/public` (#26239) --- app/models/public_feed.rb | 4 ++-- spec/requests/api/v1/timelines/public_spec.rb | 7 +++++++ 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/app/models/public_feed.rb b/app/models/public_feed.rb index 1cfd9a500..c208d6f66 100644 --- a/app/models/public_feed.rb +++ b/app/models/public_feed.rb @@ -45,11 +45,11 @@ class PublicFeed end def local_only? - options[:local] + options[:local] && !options[:remote] end def remote_only? - options[:remote] + options[:remote] && !options[:local] end def account? diff --git a/spec/requests/api/v1/timelines/public_spec.rb b/spec/requests/api/v1/timelines/public_spec.rb index 7ed0fee2d..c43626240 100644 --- a/spec/requests/api/v1/timelines/public_spec.rb +++ b/spec/requests/api/v1/timelines/public_spec.rb @@ -56,6 +56,13 @@ describe 'Public' do it_behaves_like 'a successful request to the public timeline' end + context 'with local and remote params' do + let(:params) { { local: true, remote: true } } + let(:expected_statuses) { [local_status, remote_status, media_status] } + + it_behaves_like 'a successful request to the public timeline' + end + context 'with only_media param' do let(:params) { { only_media: true } } let(:expected_statuses) { [media_status] } From 9a8190da4a7a5bd74df36ae076573e014b254ef0 Mon Sep 17 00:00:00 2001 From: Antonin Del Fabbro <30950182+AntoninDelFabbro@users.noreply.github.com> Date: Wed, 23 Aug 2023 15:51:07 +0200 Subject: [PATCH 2/3] Change opacity of the delete icon in the search field to be more visible (#26449) --- app/javascript/styles/mastodon/components.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/app/javascript/styles/mastodon/components.scss b/app/javascript/styles/mastodon/components.scss index 664f6ca02..7e7bf4488 100644 --- a/app/javascript/styles/mastodon/components.scss +++ b/app/javascript/styles/mastodon/components.scss @@ -5125,6 +5125,7 @@ a.status-card { &.active { transform: rotate(90deg); + opacity: 1; } &:hover { From e3fd07197379f1ac7fd4a761b3ff55effa1a2a6c Mon Sep 17 00:00:00 2001 From: "renovate[bot]" <29139614+renovate[bot]@users.noreply.github.com> Date: Thu, 24 Aug 2023 09:03:40 +0200 Subject: [PATCH 3/3] Update dependency rspec-sidekiq to v4 (#26627) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> --- Gemfile | 2 +- Gemfile.lock | 12 +++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/Gemfile b/Gemfile index 4c3e5a368..6f20ff25a 100644 --- a/Gemfile +++ b/Gemfile @@ -110,7 +110,7 @@ group :test do gem 'fuubar', '~> 2.5' # Extra RSpec extenion methods and helpers for sidekiq - gem 'rspec-sidekiq', '~> 3.1' + gem 'rspec-sidekiq', '~> 4.0' # Browser integration testing gem 'capybara', '~> 3.39' diff --git a/Gemfile.lock b/Gemfile.lock index e3d9eac96..f801b1b56 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -633,10 +633,12 @@ GEM rspec-expectations (~> 3.12) rspec-mocks (~> 3.12) rspec-support (~> 3.12) - rspec-sidekiq (3.1.0) - rspec-core (~> 3.0, >= 3.0.0) - sidekiq (>= 2.4.0) - rspec-support (3.12.0) + rspec-sidekiq (4.0.1) + rspec-core (~> 3.0) + rspec-expectations (~> 3.0) + rspec-mocks (~> 3.0) + sidekiq (>= 5, < 8) + rspec-support (3.12.1) rspec_chunked (0.6) rubocop (1.56.1) base64 (~> 0.1.1) @@ -911,7 +913,7 @@ DEPENDENCIES redis-namespace (~> 1.10) rqrcode (~> 2.2) rspec-rails (~> 6.0) - rspec-sidekiq (~> 3.1) + rspec-sidekiq (~> 4.0) rspec_chunked (~> 0.6) rubocop rubocop-capybara