Fix glitch local settings navigation items not being proper buttons (#2320)

local
Claire 10 months ago committed by GitHub
parent dd09535bda
commit 49767d20bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 6
      app/javascript/flavours/glitch/features/local_settings/navigation/item/index.jsx
  2. 5
      app/javascript/flavours/glitch/styles/components/local_settings.scss

@ -58,16 +58,14 @@ export default class LocalSettingsPage extends PureComponent {
</a>
);
else if (onNavigate) return (
<a
<button
onClick={handleClick}
role='button'
tabIndex={0}
className={finalClassName}
title={title}
aria-label={title}
>
{iconElem} <span>{title}</span>
</a>
</button>
);
else return null;
}

@ -56,11 +56,16 @@
padding: 15px 20px;
color: inherit;
background: lighten($ui-secondary-color, 8%);
border: 0;
border-bottom: 1px $ui-secondary-color solid;
cursor: pointer;
text-decoration: none;
outline: none;
transition: background 0.3s;
box-sizing: border-box;
width: 100%;
text-align: start;
font-size: inherit;
.text-icon-button {
color: inherit;

Loading…
Cancel
Save