Autofix Rubocop Rails/Blank (#23765)

local
Nick Schonning 1 year ago committed by GitHub
parent 8fd3fc404d
commit 4ff44be134
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 7
      .rubocop_todo.yml
  2. 2
      app/services/activitypub/fetch_remote_actor_service.rb

@ -1485,13 +1485,6 @@ Rails/ApplicationController:
- 'app/controllers/well_known/nodeinfo_controller.rb'
- 'app/controllers/well_known/webfinger_controller.rb'
# Offense count: 1
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
Rails/Blank:
Exclude:
- 'app/services/activitypub/fetch_remote_actor_service.rb'
# Offense count: 35
# Configuration parameters: Database, Include.
# SupportedDatabases: mysql, postgresql

@ -28,7 +28,7 @@ class ActivityPub::FetchRemoteActorService < BaseService
raise Error, "Unsupported JSON-LD context for document #{uri}" unless supported_context?
raise Error, "Unexpected object type for actor #{uri} (expected any of: #{SUPPORTED_TYPES})" unless expected_type?
raise Error, "Actor #{uri} has moved to #{@json['movedTo']}" if break_on_redirect && @json['movedTo'].present?
raise Error, "Actor #{uri} has no 'preferredUsername', which is a requirement for Mastodon compatibility" unless @json['preferredUsername'].present?
raise Error, "Actor #{uri} has no 'preferredUsername', which is a requirement for Mastodon compatibility" if @json['preferredUsername'].blank?
@uri = @json['id']
@username = @json['preferredUsername']

Loading…
Cancel
Save