Migrate to request specs in `/api/v1/timelines/public` (#25746)
Co-authored-by: Claire <claire.github-309c@sitedethib.com>local
parent
55cf18b689
commit
5a7c6c6597
2 changed files with 109 additions and 56 deletions
@ -1,56 +0,0 @@ |
||||
# frozen_string_literal: true |
||||
|
||||
require 'rails_helper' |
||||
|
||||
describe Api::V1::Timelines::PublicController do |
||||
render_views |
||||
|
||||
let(:user) { Fabricate(:user) } |
||||
|
||||
before do |
||||
allow(controller).to receive(:doorkeeper_token) { token } |
||||
end |
||||
|
||||
context 'with a user context' do |
||||
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id) } |
||||
|
||||
describe 'GET #show' do |
||||
before do |
||||
PostStatusService.new.call(user.account, text: 'New status from user for federated public timeline.') |
||||
end |
||||
|
||||
it 'returns http success' do |
||||
get :show |
||||
|
||||
expect(response).to have_http_status(200) |
||||
expect(response.headers['Link'].links.size).to eq(2) |
||||
end |
||||
end |
||||
|
||||
describe 'GET #show with local only' do |
||||
before do |
||||
PostStatusService.new.call(user.account, text: 'New status from user for local public timeline.') |
||||
end |
||||
|
||||
it 'returns http success' do |
||||
get :show, params: { local: true } |
||||
|
||||
expect(response).to have_http_status(200) |
||||
expect(response.headers['Link'].links.size).to eq(2) |
||||
end |
||||
end |
||||
end |
||||
|
||||
context 'without a user context' do |
||||
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: nil) } |
||||
|
||||
describe 'GET #show' do |
||||
it 'returns http success' do |
||||
get :show |
||||
|
||||
expect(response).to have_http_status(200) |
||||
expect(response.headers['Link']).to be_nil |
||||
end |
||||
end |
||||
end |
||||
end |
@ -0,0 +1,109 @@ |
||||
# frozen_string_literal: true |
||||
|
||||
require 'rails_helper' |
||||
|
||||
describe 'Public' do |
||||
let(:user) { Fabricate(:user) } |
||||
let(:scopes) { 'read:statuses' } |
||||
let(:token) { Fabricate(:accessible_access_token, resource_owner_id: user.id, scopes: scopes) } |
||||
let(:headers) { { 'Authorization' => "Bearer #{token.token}" } } |
||||
|
||||
shared_examples 'a successful request to the public timeline' do |
||||
it 'returns the expected statuses successfully', :aggregate_failures do |
||||
subject |
||||
|
||||
expect(response).to have_http_status(200) |
||||
expect(body_as_json.pluck(:id)).to match_array(expected_statuses.map { |status| status.id.to_s }) |
||||
end |
||||
end |
||||
|
||||
describe 'GET /api/v1/timelines/public' do |
||||
subject do |
||||
get '/api/v1/timelines/public', headers: headers, params: params |
||||
end |
||||
|
||||
let!(:private_status) { Fabricate(:status, visibility: :private) } # rubocop:disable RSpec/LetSetup |
||||
let!(:local_status) { Fabricate(:status, account: Fabricate.build(:account, domain: nil)) } |
||||
let!(:remote_status) { Fabricate(:status, account: Fabricate.build(:account, domain: 'example.com')) } |
||||
let!(:media_status) { Fabricate(:status, media_attachments: [Fabricate.build(:media_attachment)]) } |
||||
|
||||
let(:params) { {} } |
||||
|
||||
context 'when the instance allows public preview' do |
||||
let(:expected_statuses) { [local_status, remote_status, media_status] } |
||||
|
||||
context 'with an authorized user' do |
||||
it_behaves_like 'a successful request to the public timeline' |
||||
end |
||||
|
||||
context 'with an anonymous user' do |
||||
let(:headers) { {} } |
||||
|
||||
it_behaves_like 'a successful request to the public timeline' |
||||
end |
||||
|
||||
context 'with local param' do |
||||
let(:params) { { local: true } } |
||||
let(:expected_statuses) { [local_status, media_status] } |
||||
|
||||
it_behaves_like 'a successful request to the public timeline' |
||||
end |
||||
|
||||
context 'with remote param' do |
||||
let(:params) { { remote: true } } |
||||
let(:expected_statuses) { [remote_status] } |
||||
|
||||
it_behaves_like 'a successful request to the public timeline' |
||||
end |
||||
|
||||
context 'with only_media param' do |
||||
let(:params) { { only_media: true } } |
||||
let(:expected_statuses) { [media_status] } |
||||
|
||||
it_behaves_like 'a successful request to the public timeline' |
||||
end |
||||
|
||||
context 'with limit param' do |
||||
let(:params) { { limit: 1 } } |
||||
|
||||
it 'returns only the requested number of statuses', :aggregate_failures do |
||||
subject |
||||
|
||||
expect(response).to have_http_status(200) |
||||
expect(body_as_json.size).to eq(params[:limit]) |
||||
end |
||||
|
||||
it 'sets the correct pagination headers', :aggregate_failures do |
||||
subject |
||||
|
||||
headers = response.headers['Link'] |
||||
|
||||
expect(headers.find_link(%w(rel prev)).href).to eq(api_v1_timelines_public_url(limit: 1, min_id: media_status.id.to_s)) |
||||
expect(headers.find_link(%w(rel next)).href).to eq(api_v1_timelines_public_url(limit: 1, max_id: media_status.id.to_s)) |
||||
end |
||||
end |
||||
end |
||||
|
||||
context 'when the instance does not allow public preview' do |
||||
before do |
||||
Form::AdminSettings.new(timeline_preview: false).save |
||||
end |
||||
|
||||
context 'with an authenticated user' do |
||||
let(:expected_statuses) { [local_status, remote_status, media_status] } |
||||
|
||||
it_behaves_like 'a successful request to the public timeline' |
||||
end |
||||
|
||||
context 'with an unauthenticated user' do |
||||
let(:headers) { {} } |
||||
|
||||
it 'returns http unprocessable entity' do |
||||
subject |
||||
|
||||
expect(response).to have_http_status(422) |
||||
end |
||||
end |
||||
end |
||||
end |
||||
end |
Loading…
Reference in new issue