Add coverage for `URLValidator` (#25591)
parent
6602edf064
commit
660993b415
2 changed files with 68 additions and 21 deletions
@ -1,16 +1,31 @@ |
||||
# frozen_string_literal: true |
||||
|
||||
class URLValidator < ActiveModel::EachValidator |
||||
VALID_SCHEMES = %w(http https).freeze |
||||
|
||||
def validate_each(record, attribute, value) |
||||
record.errors.add(attribute, :invalid) unless compliant?(value) |
||||
@value = value |
||||
|
||||
record.errors.add(attribute, :invalid) unless compliant_url? |
||||
end |
||||
|
||||
private |
||||
|
||||
def compliant?(url) |
||||
parsed_url = Addressable::URI.parse(url) |
||||
parsed_url && %w(http https).include?(parsed_url.scheme) && parsed_url.host |
||||
def compliant_url? |
||||
parsed_url.present? && valid_url_scheme? && valid_url_host? |
||||
end |
||||
|
||||
def parsed_url |
||||
Addressable::URI.parse(@value) |
||||
rescue Addressable::URI::InvalidURIError |
||||
false |
||||
end |
||||
|
||||
def valid_url_scheme? |
||||
VALID_SCHEMES.include?(parsed_url.scheme) |
||||
end |
||||
|
||||
def valid_url_host? |
||||
parsed_url.host.present? |
||||
end |
||||
end |
||||
|
Loading…
Reference in new issue