Fix `UserCleanupScheduler` crash when an unconfirmed account has a moderation note (#23318)
* Fix `UserCleanupScheduler` crash when an unconfirmed account has a moderation note * Add testslocal
parent
523a86618f
commit
9edefc779f
2 changed files with 40 additions and 1 deletions
@ -0,0 +1,39 @@ |
||||
require 'rails_helper' |
||||
|
||||
describe Scheduler::UserCleanupScheduler do |
||||
subject { described_class.new } |
||||
|
||||
let!(:new_unconfirmed_user) { Fabricate(:user) } |
||||
let!(:old_unconfirmed_user) { Fabricate(:user) } |
||||
let!(:confirmed_user) { Fabricate(:user) } |
||||
let!(:moderation_note) { Fabricate(:account_moderation_note, account: Fabricate(:account), target_account: old_unconfirmed_user.account) } |
||||
|
||||
describe '#perform' do |
||||
before do |
||||
# Need to update the already-existing users because their initialization overrides confirmation_sent_at |
||||
new_unconfirmed_user.update!(confirmed_at: nil, confirmation_sent_at: Time.now.utc) |
||||
old_unconfirmed_user.update!(confirmed_at: nil, confirmation_sent_at: 1.week.ago) |
||||
confirmed_user.update!(confirmed_at: 1.day.ago) |
||||
end |
||||
|
||||
it 'deletes the old unconfirmed user' do |
||||
expect { subject.perform }.to change { User.exists?(old_unconfirmed_user.id) }.from(true).to(false) |
||||
end |
||||
|
||||
it "deletes the old unconfirmed user's account" do |
||||
expect { subject.perform }.to change { Account.exists?(old_unconfirmed_user.account_id) }.from(true).to(false) |
||||
end |
||||
|
||||
it 'does not delete the new unconfirmed user or their account' do |
||||
subject.perform |
||||
expect(User.exists?(new_unconfirmed_user.id)).to be true |
||||
expect(Account.exists?(new_unconfirmed_user.account_id)).to be true |
||||
end |
||||
|
||||
it 'does not delete the confirmed user or their account' do |
||||
subject.perform |
||||
expect(User.exists?(confirmed_user.id)).to be true |
||||
expect(Account.exists?(confirmed_user.account_id)).to be true |
||||
end |
||||
end |
||||
end |
Loading…
Reference in new issue